fix: 🐛 Fix paginator implementation when only passing PageGroup objects and show_menu is falsy
#2993
+20
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and `show_menu` is falsy
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/2993/head:pr-2993
git checkout pr-2993This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/2993/head |
Lulalaby
previously approved these changes
Nov 7, 2025
Signed-off-by: Paillat <paillat@pycord.dev>
Contributor
|
maybe this erroring could be improved return pages.Paginator(
show_menu=True,
pages=[pages.Page(embeds=[embed]) for embed in embeds],
custom_view=BotAliasView(bot, translator, author_id),
)
```
raise `Command raised an exception: TypeError: 'NoneType' object is not iterable`into -> PageGroup cant be None with show_menu true
else tested and lgtm with show_menu = False |
Member
Author
|
I agree, but I didn't add the error in this PR so I'm not gonna change it here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes : #2992
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.